Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define isLocalCommitTx and refactor contractcourt to use it #8920

Open
ProofOfKeags opened this issue Jul 18, 2024 · 0 comments
Open

Define isLocalCommitTx and refactor contractcourt to use it #8920

ProofOfKeags opened this issue Jul 18, 2024 · 0 comments

Comments

@ProofOfKeags
Copy link
Collaborator

Originating from this comment from @Roasbeef, we wish to have a minimal function that can reliably identify whether a broadcasted commitment transaction is ours or our peer's.

The suggested design is to create a pure function with the following type signature:

isLocalCommitTx :: ChannelType -> LocalChanCfg -> wire.MsgTx -> SignDescriptor -> bool

There is an open question about wether or not we need the fully formed SignDescriptor for this or just a piece of it. Once we have this function, we can improve the contractcourt code specifically in the commitSweepResolver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant