[bug]: lncli listpayments --count_total_payments should honor --creation_date_start --creation_date_end

[AndySchroder]

Background

lncli listpayments --count_total_payments should honor --creation_date_start and --creation_date_end

Steps to reproduce

$ lncli listpayments --count_total_payments|grep total_num_payments
    "total_num_payments": "30560"
$

and

$ lncli listpayments --creation_date_start 1650000000 --count_total_payments --creation_date_end 1650000001|grep total_num_payments
    "total_num_payments": "30560"
$

both yield the same thing.

I would expect

$ lncli listpayments --creation_date_start 1650000000 --count_total_payments --creation_date_end 1650000001|grep total_num_payments
    "total_num_payments": "0"
$

[natalypeyioti]

I would like to work on this issue! Can I take it?

[violetguos]

Hi @AndySchroder , since the issue doesn't have an assignee, I took a stab at it. Could you please have a look? I already answered the bot reviewer's questions

[AndySchroder]

Okay, looks like #8565 has been cancelled and this issue will need a new attempt.

[MPins]

Okay, looks like #8565 has been cancelled and this issue will need a new attempt.

I've been investigating this issue and the code associated with it ... The function QueryPayments is not considering the data filtering when counting the numbers of payments.

I would like to do a new attempt to solve it.