Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: sending update_fail_malformed_htlc with error code 4103 (aka temporary_channel_failure)? #7851

Closed
rustyrussell opened this issue Jul 22, 2023 · 1 comment · Fixed by #7937
Assignees
Labels
bug Unintended code behaviour interop interop with other implementations
Milestone

Comments

@rustyrussell
Copy link

Background

Report that Bitrefill is sending these, and CLN is issuing a warning and closing the connection:

ElementsProject/lightning#6425

Seems weird, but pretty sure they're LND?

Steps to reproduce

It obviously doesn't happen very often: the result of this would be a channel closure when we eventually get sick of the HTLC and it times out.

Posting here in case it's a known issue or been reported before?

@rustyrussell rustyrussell added bug Unintended code behaviour needs triage labels Jul 22, 2023
@Roasbeef
Copy link
Member

Perhaps there's an onion replay happening somewhere in the route? See this issue for an example: #5792 (comment)

There's a known bug where we don't properly transform the error internally before sending out on the wire: #5443 (comment). Looks like this fell through the cracks shortly after the realization in that issue, will reprio....

@saubyk saubyk added this to the v0.18.0 milestone Aug 4, 2023
@saubyk saubyk added this to lnd v0.18 Aug 8, 2023
@saubyk saubyk moved this to 🔖 Ready in lnd v0.18 Aug 8, 2023
@saubyk saubyk added interop interop with other implementations and removed needs triage labels Aug 8, 2023
@ProofOfKeags ProofOfKeags removed their assignment Aug 25, 2023
@saubyk saubyk moved this from 🔖 Ready to 👀 In review in lnd v0.18 Aug 30, 2023
@saubyk saubyk modified the milestones: v0.18.0, v0.17.1 Oct 5, 2023
@saubyk saubyk removed this from lnd v0.18 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended code behaviour interop interop with other implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants