Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: add more filter options to ListPaymentsRequest and ListInvoiceRequest #7626

Open
AndySchroder opened this issue Apr 22, 2023 · 1 comment
Labels
enhancement Improvements to existing features / behaviour rpc Related to the RPC interface

Comments

@AndySchroder
Copy link

Is your feature request related to a problem? Please describe.

Too much data transfer and client side filtering: AKA Zeus is unusable with 30K payments.

Describe the solution you'd like

ListPaymentsRequest has some nice filtering capability

  • include_incomplete
  • index_offset
  • max_payments
  • reversed
  • creation_date_start
  • creation_date_end

It would be nice to also be able to filter the invoice amount paid (max and/or min), as well as a memo search query. We may have many small payments over a small time period that we don't want to look at.

ListInvoiceRequest has

  • pending_only
  • index_offset
  • num_max_invoices
  • reversed
  • creation_date_start
  • creation_date_end

For invoices, it would also be nice to also be able to filter the invoice amount (max or min), as well as a memo search query. Additionally, it would be nice to be able to show paid invoices only instead of showing unpaid invoices only.

Describe alternatives you've considered

They're all slow.

@AndySchroder
Copy link
Author

Would also be nice to be able to filter out keysend/AMP payments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour rpc Related to the RPC interface
Projects
None yet
Development

No branches or pull requests

2 participants