Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Inline SVGs in a platform independent way #289

Closed
tanx opened this issue Mar 29, 2018 · 0 comments
Closed

Inline SVGs in a platform independent way #289

tanx opened this issue Mar 29, 2018 · 0 comments
Assignees
Labels

Comments

@tanx
Copy link
Contributor

tanx commented Mar 29, 2018

I've looked into how we can leverage the svgr compiler in order to inline SVGs into react components. This is required because the react-native Image component doesn't support svg files on iOS and Android. Rather we need to use react-native-svg to draw SVG using native primitives. In order to leverage the same react-native-svg components in electron together with react-native-web, I've created a PR to create-react-app:

facebook/create-react-app#4224

Once this PR is merged we should be able to use a single SVG format on all platforms. Inlining SVGs also has the advantage that we can style them using CSS and don't need to edit colors in Sketch.

I've already gotten the svgr compiler to work on a branch: 7ce81a2

@tanx tanx added ios and removed v0.2 labels Apr 18, 2018
@tanx tanx self-assigned this Aug 8, 2018
@tanx tanx removed the help wanted label Aug 9, 2018
@tanx tanx mentioned this issue Aug 15, 2018
@tanx tanx closed this as completed in #521 Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant