Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant {channel,node}_announcement signature checks #3305

Merged
merged 1 commit into from
Sep 10, 2024
+70 −45

Avoid redundant `{channel,node}_announcement` signature checks

56cb6a1
Select commit
Loading
Failed to load commit list.
Merged

Avoid redundant {channel,node}_announcement signature checks #3305

Avoid redundant `{channel,node}_announcement` signature checks
56cb6a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 9, 2024 in 0s

89.62% (-0.23%) compared to d35239c

View this Pull Request on Codecov

89.62% (-0.23%) compared to d35239c

Details

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (d35239c) to head (56cb6a1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/routing/gossip.rs 84.21% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3305      +/-   ##
==========================================
- Coverage   89.85%   89.62%   -0.23%     
==========================================
  Files         126      126              
  Lines      104145   102181    -1964     
  Branches   104145   102181    -1964     
==========================================
- Hits        93577    91582    -1995     
+ Misses       7894     7877      -17     
- Partials     2674     2722      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov