Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe only up to the last public hop if there's no other choices #2517

Closed
Tracked by #2534
TheBlueMatt opened this issue Aug 23, 2023 · 1 comment · Fixed by #2534
Closed
Tracked by #2534

Probe only up to the last public hop if there's no other choices #2517

TheBlueMatt opened this issue Aug 23, 2023 · 1 comment · Fixed by #2534
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

If we're doing pre-flight probing for a payment, and the last hop is from an invoice route hint, and there's only one option for the last-hop route, and the node is not public, there's no reason to probe through to the endpoint - we might as well probe to the second-to-last hop. Worse, probing to the endpoint may confuse some LSPs, causing them to open a JIT channel when there's no real payment yet. For ldk-node this should be ~easy, for LDK itself we probably want to do it as a part of #2499.

cc @tnull

@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Aug 23, 2023
@tnull
Copy link
Contributor

tnull commented Aug 23, 2023

Yup, will make sure to include it in #2499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants