Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject HTLC forwarding requests if fee-bumping reserves are low #2327

Closed
ariard opened this issue May 31, 2023 · 2 comments
Closed

Reject HTLC forwarding requests if fee-bumping reserves are low #2327

ariard opened this issue May 31, 2023 · 2 comments

Comments

@ariard
Copy link

ariard commented May 31, 2023

If the numbers of pending HTLCs is too high and our fee-bumping reserves are too low, we should reject new HTLC forwarding request to avoid a situation where we cannot cover high feerates at current level of network mempools congestion. This type of mechanism is not implemented by any Lightning implementation, afaik.

This type of checks could be introduced in the same code path where we're checking other BOLT4 checks in decode_update_add_htlc_onion() or offloaded to the LDK user if we can have a generic HTLC interception interface.

Sounds a follow-up of #2089 and #2320.

@TheBlueMatt
Copy link
Collaborator

This really should just be a part of the greater approach to #2320. Let's not blow up our issue count :)

@ariard
Copy link
Author

ariard commented Jul 9, 2023

This really should just be a part of the greater approach to #2320. Let's not blow up our issue count :)

At the same time when the issue can be implemented on its own granularly, can be its own. Yeah merging it with #2320.

@ariard ariard closed this as completed Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants