Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DNS hostnames in gossip #1313

Closed
TheBlueMatt opened this issue Feb 16, 2022 · 5 comments · Fixed by #1553
Closed

Support DNS hostnames in gossip #1313

TheBlueMatt opened this issue Feb 16, 2022 · 5 comments · Fixed by #1553
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

See lightning/bolts#911

@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Feb 16, 2022
@ritikramuka
Copy link

Greetings everyone, 👋
I'd be happy to work on this issue.
I'm new to this project and I just started learning rust to contribute here. I hope this will be a good starting point for contributing.

Can I take this up? I'll also be glad to be guided a bit.

@TheBlueMatt
Copy link
Collaborator Author

Sure, this is basically as simple as adding a new variant to the NetAddress type.

@ritikramuka
Copy link

I am completely new to this so could you provide some more details. I am unable to figure out where to add this new variant to the NetAddress type.

@TheBlueMatt
Copy link
Collaborator Author

Just take a look at how the existing variants work (eg OnionV3, etc) and add a parallel one for DNSHostname :). More guidance than that and I'd just write the code.

@mauricepoirrier
Copy link

Hey @ritikramuka 👋🏼
I started checking out this issue but I didn't write anything. I just pushed some code maybe we could see it together as is my first issue too. What do you think? :)

@tnull tnull linked a pull request Jun 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
3 participants