Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reference the underspecified (and generally discouraged) BIP 69 #456

Closed
TheBlueMatt opened this issue Jul 26, 2018 · 1 comment · Fixed by #876
Closed

Do not reference the underspecified (and generally discouraged) BIP 69 #456

TheBlueMatt opened this issue Jul 26, 2018 · 1 comment · Fixed by #876

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Jul 26, 2018

Instead of saying that transactions should follow BIP 69, we should write out what that means, given BIP 69 isn't even well-specified itself (and to avoid the implied support for BIP 69, which generally is strongly discouraged for things that don't look like Lightning). See-also lightningdevkit/rust-lightning#84

@rustyrussell
Copy link
Collaborator

Do you have a reference for BIP 69 being strongly discouraged? I've considered we should go the other way and make it compulsory, but that requires a replacement for SIGHASH_SINGLE, which means never...

Either way, we'll be dealing with this explicitly in #448 because it turns out ordering everything canonically requires more than knowing the tx...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants