-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add masked average pooling for pooling with segmentation masks (DetCon) #1739
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1739 +/- ##
==========================================
+ Coverage 85.21% 85.22% +0.01%
==========================================
Files 162 162
Lines 6708 6729 +21
==========================================
+ Hits 5716 5735 +19
- Misses 992 994 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Left some comments regarding formatting and code structure but the logic looks correct
Co-authored-by: guarin <43336610+guarin@users.noreply.github.com>
Co-authored-by: guarin <43336610+guarin@users.noreply.github.com>
Co-authored-by: guarin <43336610+guarin@users.noreply.github.com>
…lightly-ai/lightly into lionel-lig-5627-figure-out-mask-pooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left one more comment but feel free to resolve and merge.
Changes
How has it been tested