This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Avoid recreating the metrics for each cluster to support global labels #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anbarasantr
changed the title
seglo
reviewed
Sep 25, 2019
src/main/scala/com/lightbend/kafkalagexporter/PrometheusEndpointSink.scala
Outdated
Show resolved
Hide resolved
| "environment" -> "prod", | ||
| "org" -> "organization2", | ||
| "location" -> "canada" | ||
| ) |
There was a problem hiding this comment.
It's possible for clusters with no labels defined to report metrics. When you use the Strimzi cluster watcher, clusters are added at runtime and will have an empty set of labels. Can you add/update a test to include a cluster with labels defined, and one with none defined, and assert that it works. I assume the result would be blank label values for the clusters that have none defined.
There was a problem hiding this comment.
@seglo Nice catch :) I added those test cases and made some minor changes in the implementation to accommodate this requirement.
seglo
reviewed
Sep 25, 2019
src/main/scala/com/lightbend/kafkalagexporter/PrometheusEndpointSink.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/lightbend/kafkalagexporter/PrometheusEndpointSink.scala
Outdated
Show resolved
Hide resolved
seglo
reviewed
Sep 26, 2019
seglo
approved these changes
Sep 30, 2019
anbarasantr
added a commit
to anbarasantr/kafka-lag-exporter
that referenced
this pull request
Nov 24, 2019
seglo#82) * Avoid recreating the metrics for each cluster * Handle global labels for `Strimzi` cluster watcher logic * Refactored as per the comments * Updated docs as per suggestion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reproduced in 78.
Java prometheus client library does not let us register metrics more than once with different sets of labels. The idea is not to register prometheus metrics for each cluster and to create once with all the labels defined in all the cluster.