Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Adds custom labels for every cluster #61

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Conversation

anbarasantr
Copy link
Contributor

This fixes 34. This would help to specify custom / additional labels which could be specified per cluster.

Example:

kafka-lag-exporter {
  port = 9999
  lookup-table-size = 60
  clusters = [
    {
      name = "us-east_ny_a-cluster"                                   
      bootstrap-brokers = "us-east_ny_a-1.cluster-a.xyzcorp.com:9092,us-east_ny_a-2.cluster-a.xyzcorp.com:9092,us-east_ny_a-3.cluster-a.xyzcorp.com:9092"
      labels {
        location = "ny"
        zone = "us-east"
      }
    }
  ]
}

This would simplify the Prometheus job config. Because now Prometheus relabelling tricks must be applied to get this labels.

@lightbend-cla-validator

Hi @anbarasantr,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@anbarasantr
Copy link
Contributor Author

@seglo I have signed the agreement, can you please review this PR ?

Copy link
Owner

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @anbarasantr. This looks good! I've made some mostly minor requests.

README.md Outdated Show resolved Hide resolved
src/main/resources/reference.conf Outdated Show resolved Hide resolved
@anbarasantr
Copy link
Contributor Author

@seglo Thanks for the suggestions. I have fixed it.

@seglo seglo self-requested a review September 14, 2019 16:09
Copy link
Owner

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@seglo seglo merged commit c509d19 into seglo:master Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom / additional labels
3 participants