Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngularJS directive template usage comment not displaying proper values #285

Closed
kentcooper opened this issue Jul 3, 2015 · 7 comments · Fixed by #340
Closed

AngularJS directive template usage comment not displaying proper values #285

kentcooper opened this issue Jul 3, 2015 · 7 comments · Fixed by #340
Assignees
Labels
Milestone

Comments

@kentcooper
Copy link
Member

Not sure if we will be able to resolve it or not but in the directive template there is a usage example that when the $safeitemname$ is camel case the comment is not correct. For example when the directive name is directTest you end up with this:

  .directive('directiveTest', directiveTest);

    // Usage:
    //     <directiveTest></directiveTest>

when it should be:

   .directive('directiveTest', directiveTest);

    // Usage:
    //     <directive-test></directive-test>

Issue comes from https://visualstudiogallery.msdn.microsoft.com/a16c2d07-b2e1-4a25-87d9-194f04e7a698 QA section

@johnpapa
Copy link
Contributor

johnpapa commented Aug 8, 2015

ah. hmmm. is there a camelCaserizer ? :)

@johnpapa
Copy link
Contributor

johnpapa commented Aug 8, 2015

or a dasherizer?

@sayedihashimi
Copy link
Member

I think we will need a custom wizard for this. If you can create a class to convert the strings I can help with the wizard part.

@johnpapa
Copy link
Contributor

johnpapa commented Aug 8, 2015

@kentcooper
Copy link
Member Author

@johnpapa that looks like its for _ to - we would need camelCase to dash right? I can write the class to do that part of it if we can't find one.

@johnpapa
Copy link
Contributor

johnpapa commented Aug 8, 2015

could be useful too.

@kentcooper
Copy link
Member Author

true. Checked the directive snippet as well but that doesn't seem to include the actual usage so we should be good there.

@kentcooper kentcooper self-assigned this Sep 7, 2015
@codewithtyler codewithtyler added this to the 1.21 milestone Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants