-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit on startup with WaitDone true takes 3-4s #1749
Comments
Log output:
|
Looks like:
Is a big chunk of it (755ms). Any idea why that's taking so long? Looks like 807ms after the last vpp startup log message... so it maynot be vpp startup time:
But only 672ms after I initiated my call (important to note for the timeline later):
|
Looks like ~312ms is vppagent-plugin initialization.
Of which the biggest culprit seem to be DHCP(261ms):
|
And then there's this weird 1.831s gap in the logs between the end of plugin initialization and the Push to KV notifications:
And note the 2.817s gap between when I send the UPDATE and when it starts going into the KV store:
|
And then its taking 673ms to do the actual configuration work... which seems extremely long.
But then once work is done you are returning nearly instantly. |
Timeline:
Which totals to:
|
vppagent version from the go.mod:
And the Dockerfile:
|
From my perspective, this issue has nothing to do with WaitDone. There are definitely things that can be optimized regarding agent initialization.
Are you certain some attempts to connect did not fail before this? It seems like that is first line from agent.. so the log output is probably cut off before that. Try tweaking Further, you could also set My image locally starts VPP in ~200ms.
This is the other important time. It's time it takes to start all agent components - which is done synchronously and might start goroutines in second pahase. The "connecting to VPP" is a part of this duration. |
|
Here's the logs with DEBUG_GO_VPP=true from the very beginning to the first return from calling Update, which took 1.22s:
|
It appears to take 166ms to connect to vpp.
Which is a little odd given that judging by the last log message from vpp... it had been up for 118ms before vpp-agent started. |
It appears to have taken 722ms from when vppagent-connected to vpp till it was ready to begin its first execution. Of that,
|
Placeholder
The text was updated successfully, but these errors were encountered: