Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite recursion in the semantics #504

Closed
DCNick3 opened this issue Apr 14, 2021 · 2 comments · Fixed by #507
Closed

Infinite recursion in the semantics #504

DCNick3 opened this issue Apr 14, 2021 · 2 comments · Fixed by #507
Labels
bug good first issue x86 Related to x86/x86-64/AMD64 lifting support

Comments

@DCNick3
Copy link
Contributor

DCNick3 commented Apr 14, 2021

It seems that the implementation of the FCOMP (and FUCOMP) with memory argument results in an infinite recursion:

template <typename S2>
DEF_FPU_SEM(FUCOMPmem, RF80 src1, S2 src2) {
  SetFPUDp(src2);
  return FUCOMPmem(memory, state, src1, src2, pc, fop);
}

template <typename S2>
DEF_FPU_SEM(FCOMPmem, RF80 src1, S2 src2) {
  SetFPUDp(src2);
  return FCOMPmem(memory, state, src1, src2, pc, fop);
}

Probably some other function should have been called...

@pgoodman pgoodman added bug good first issue x86 Related to x86/x86-64/AMD64 lifting support labels Apr 14, 2021
@pgoodman
Copy link
Contributor

@DCNick3 good find! Can you submit a PR that calls whatever was meant to be called?

@DCNick3
Copy link
Contributor Author

DCNick3 commented Apr 14, 2021

I think if I will poke around I will find which one is meant to be called and submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue x86 Related to x86/x86-64/AMD64 lifting support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants