-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add close button on mobile #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhikumar98 I like the idea. There are some small inaccuracies though
- Icons should be the same size, including hover effects.
- Default mode has unnecessary space on the right of the settings button.
Pushed the changes 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chybisov, I've pushed the fixes though. |
@Abhikumar98, it seems like the fix made things worse. 😅 We should have equal indent between icons and also use |
Open to suggestions on the placement of the button 😂