-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do periodic security update #4459
Comments
I verified the changes in these dependencies and the only problem I see is that the "react-docgen" directory is something we add manually to the repository. Last time we updated it, was here. This seems like a manual process so I'm not sure what we want to do about these dependabot alerts. W |
Hey @julien, yeah we keep it local due to a bug we had to fix locally I don't remember why this fix wasn't sent to Usually, we will try to follow the policy that was created and keep this issue open to decide what to do with the alerts that appear, ideally it would be interesting to keep dependabot on despite being quite annoying at times, but at least in our repository it seems to be rare. About |
@matuzalemsteles thanks for the clarification. Let's see if we get time to prioritize work on #4130, |
Hey @julien I'm closing the PRs and adding the reference here so that we can track them. |
@matuzalemsteles adding these |
|
|
I should update this next week. |
|
|
Well, apparently we've started getting PRs from dependabot, as we have a policy of not merging these PRs but looking more carefully at the dependencies and checking if it makes sense and instead of manipulating
yarn.lock
to update the root dependency.This issue has the same effect as the issue that was created in the project liferay/liferay-frontend-projects#112.
The text was updated successfully, but these errors were encountered: