Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClayCard List #393

Closed
carloslancha opened this issue Dec 11, 2017 · 3 comments
Closed

ClayCard List #393

carloslancha opened this issue Dec 11, 2017 · 3 comments
Labels

Comments

@carloslancha
Copy link
Contributor

carloslancha commented Dec 11, 2017

We need card lists to be lists (in the same way list groups are).

We found that replacing <div class="row"> with <ul class="list-unstyled row"> and each card <div class="col-lg-3 col-md-4 col-sm-6"> with <li class="col-lg-3 col-md-4 col-sm-6"> do the trick, but we want to be sure about it.

Thx!

http://pat270.github.io/lexicon/content/test-card-view-template/

@yuchi
Copy link

yuchi commented Dec 11, 2017

My 2cents: a row should not be anything else or margins/padding will break too easily. (Notice: non-flex experience here)

@pat270
Copy link
Member

pat270 commented Dec 11, 2017

@carloslancha, I agree with @yuchi we shouldn't use Bootstrap's grid for this. It doesn't size or break well in all screen sizes with varying items and side navigations that we have in Portal. I'll add something (don't know what to call it) to layout the cards for you.

@pat270 pat270 added the 2.x label Dec 11, 2017
@carloslancha
Copy link
Contributor Author

Perfect, thanks @pat270 and @yuchi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants