Crash / Code dump when closing content

[cucholix]

Description

Tested with 27-07-18 nightly on Wii U, probably happens in current releases too:

When booting mame2003/mame2003-plus some games will throw an error, or freeze in a black screen when close content

The games I personaly tested were Flying Shark adn Ultimate Mortal Kombat 3, they boot fine but crash when exit them. Other games like Alien and Aero Fighters don't have this issue

@bparker06 help me testing on PC under ASAN/debug, with fshark.zip and umk3.zip this is the log he got:

==17140==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6200051abe98 at pc 0x00000087017b bp 0x7ffef3937e80 sp 0x7ffef3937e78
READ of size 2 at 0x6200051abe98 thread T0
    #0 0x87017a in convert_s16_to_float libretro-common/audio/conversion/s16_to_float.c:172
    #1 0x4cc25e in audio_driver_flush audio/audio_driver.c:626
    #2 0x4cd08d in audio_driver_sample_batch audio/audio_driver.c:782
    #3 0x7fec1137e7be in retro_run (/home/bp/.config/retroarch/cores/mame2003_libretro.so+0x87e7be)

He did test kinst.zip and it works fine

Expected behavior

Exit from the game cleanly when close content from quick menu

Steps to reproduce the bug

1. Open a mame2003/plus Content (fshark.zip or umk3.zip)
2. Bring back menu
3. Select Close Content
4. Code dump or black screen

Bisect reults

July 22, 2018 e5741eb works
July 23, 2018 6150bd9 broken

[cucholix]

Tried with mame2003-plus and the issue is gone, mame2003 still have on wiiu

[ghost]

Since you're on linux anyway, please use ASAN while testing, otherwise backtraces may be pointing to the wrong place if there's any memory corruption.

[cucholix]

Tested mame2003-plus fshark and umk3 and they no longer code dumps or black screen when closing content on Wii U (aug 7 build) =)

Haven't tried mame2003 yet.

[cucholix]

mame2003-plus works fine in latest build, will try mame2003 when I get home, thanks!