Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec reviews should have a guaranteed minimum review period #170

Closed
lanzafame opened this issue May 24, 2019 · 3 comments
Closed

Spec reviews should have a guaranteed minimum review period #170

lanzafame opened this issue May 24, 2019 · 3 comments

Comments

@lanzafame
Copy link

Reasoning outlined here.

I am not sure what the best timeframe is but I think that a week would be a good start for the minimum timeframe a spec should be open for review before potentially merging based on the consensus of those that have commented. Said another way, even if consensus is reached, the spec review should remain open for a week.

@raulk
Copy link
Member

raulk commented May 24, 2019

Not sure I follow. The process already defines a 5 working day period for initial working drafts (short on purpose to allow quicker entry into incubation) and 10 working days for Candidate Recommendations and Recommendations.

Is there something else that needs to be added now, or is this issue addressing the one-off event on merging the meta-spec (which we discussed in that issue)?

@raulk
Copy link
Member

raulk commented May 24, 2019

(And the phrasing specifically goes: “allowing X days to elapse to collect feedback from the libp2p community at large”.) I believe this addresses your concerns, in which case let’s close the issue.

@lanzafame
Copy link
Author

@raulk Ahh I was just confused as to why a similar timeframe wasn't applied to the meta-spec? I am happy to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants