Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers to make it possible to easily create a protocol #833

Closed
tomaka opened this issue Jan 8, 2019 · 3 comments
Closed

Add helpers to make it possible to easily create a protocol #833

tomaka opened this issue Jan 8, 2019 · 3 comments
Labels
difficulty:hard priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Jan 8, 2019 •
edited
Loading

It is too difficult right now to create a custom protocol.
Similarly, the complexity of kad, ping, identify is quite high. We should eventually simplify them.
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:hard labels Jan 8, 2019
@drozdziak1
Copy link

Hey, what part do you think would be the hardest to refactor?

@tomaka
Copy link
Member Author

tomaka commented Jan 15, 2019

The problem with this issue is that any helper is going to be highly opinionated.

For example we can make it easy to implement communications encoded with JSON, but people might not want to use JSON.

Figuring out the design of the thing is the hard part of this issue.

This was referenced Jan 17, 2019
Closed
Closed
Merged
@tomaka tomaka mentioned this issue Jan 28, 2019
Merged
@romanb
Copy link
Contributor

romanb commented Oct 6, 2020

I guess the new libp2p-request-response covers this issue for request-response protocols and #1727 seems to overlap with what possibly remains to do for this issue (i.e. maybe we can close this in favour of #1727)?

@tomaka tomaka closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:hard priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romanb @tomaka @drozdziak1