Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WSS to interop test impl #3576

Open
MarcoPolo opened this issue Mar 9, 2023 · 2 comments
Open

Add WSS to interop test impl #3576

MarcoPolo opened this issue Mar 9, 2023 · 2 comments
Labels
difficulty:easy help wanted

Comments

@MarcoPolo
Copy link
Contributor

Description

We now have WSS testing in the interop runner. We need this to test browsers since browsers wont connect to a non-secure ws url. We have the go-libp2p pr here: libp2p/go-libp2p#2178. It would be great to have Rust add WSS so it gets tested against browsers.

Are you planning to do it yourself in a pull request?

I would, but I feel like others could do this faster.
@thomaseizinger thomaseizinger added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:easy help wanted labels Mar 15, 2023
@thomaseizinger
Copy link
Contributor

To do this, we'll need to figure out how to make browsers trust the self-signed certificate during start-up, right?

@thomaseizinger thomaseizinger removed the priority:important The changes needed are critical for libp2p, or are blocking another project label Sep 20, 2023
@mxinden
Copy link
Member

mxinden commented Sep 22, 2023

I would expect headless browser frameworks to offer a trust-self-signed-certificates option. Pure intuition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarcoPolo @thomaseizinger @mxinden