Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wire protocol name of the "multistream-lazy" variant #1853

Closed
tomaka opened this issue Nov 23, 2020 · 0 comments · Fixed by #1855
Closed

Change wire protocol name of the "multistream-lazy" variant #1853

tomaka opened this issue Nov 23, 2020 · 0 comments · Fixed by #1855
Assignees

Comments

@tomaka
Copy link
Member

tomaka commented Nov 23, 2020

The rust-libp2p implementation of multistream-select, in addition to the standard V1 protocol version, also supports a non-standard V1Lazy variant.
Link to the documentation.

While this variant removes a round-trip-time in many circumstances, its drawback is that it isn't compatible with the non-Rust versions of libp2p. For that reason, nobody uses it.

I suggest here that we:

  • Change the wire name of V1Lazy to be the same as V1, therefore making indistinguishable from the standard one.
  • Remove the fact that the listener delays the response, as it is, as far as I understand, the reason why this protocol isn't the same as the standard one. The listener should immediately send back the response to the protocol request, even though it might result in two packets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants