Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to limit the number of total inbound connections #1839

Closed
tomaka opened this issue Nov 16, 2020 · 0 comments · Fixed by #1848
Closed

Add a way to limit the number of total inbound connections #1839

tomaka opened this issue Nov 16, 2020 · 0 comments · Fixed by #1848
Assignees

Comments

@tomaka
Copy link
Member

tomaka commented Nov 16, 2020

The SwarmBuilder has a way to limit the number of connections per peer, and a way to limit the number of handshaking connections, but no way to limit the total number of incoming connections.

At the moment, someone can pre-generate thousands of PeerIds, then open thousands of TCP connections to a single node, and completely clog its file descriptors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants