inline public key handling for the 0.12.x line #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobowers
force-pushed
the
feature/inline-12.x
branch
from
c91d808
to
9c34d42
Compare
|
fixed linting again |
|
Just remove this line, we removed the commitlint from CI: https://github.com/libp2p/js-peer-id/blob/0.12.x/.travis.yml#L25 |
|
done. |
vasco-santos
approved these changes
Sep 25, 2019
|
Thanks @tobowers ! I am releasing everything shortly |
|
Shipped |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This engaging PR falls hot on the heels of other PRs you have come to love like #101 .
Brings inline crypto public key handling to the 0.12.x branch as it is in the master branch.