fix: start and stop connection manager with libp2p #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@diasdavid added a test to verify subcomponents are being started and stopped along with libp2p. |
|
npm is having a bad day, I will check back tomorrow and re-run the tests when npm is feeling better. |
test: add test to verify libp2p starts and stops the right things test: add test for verifying disabled modules fix: linting
jacobheun
force-pushed
the
fix/cm-autostart
branch
from
811e4e5
to
a933570
Compare
|
@diasdavid This should be good to merge now. |
daviddias
approved these changes
Jul 22, 2018
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
…bp2p#225) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.1](libp2p/js-libp2p-tcp@v6.0.0...v6.0.1) (2022-11-16) ### Trivial Changes * **deps-dev:** bump @libp2p/interface-mocks from 7.1.0 to 8.0.1 ([libp2p#225](libp2p/js-libp2p-tcp#225)) ([a271056](libp2p/js-libp2p-tcp@a271056))
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [7.0.4](libp2p/js-libp2p-mplex@v7.0.3...v7.0.4) (2022-11-23) ### Dependencies * **dev:** bump it-map from 1.0.6 to 2.0.0 ([libp2p#225](libp2p/js-libp2p-mplex#225)) ([a153108](libp2p/js-libp2p-mplex@a153108)) ### Trivial Changes * update benchmark ([libp2p#232](libp2p/js-libp2p-mplex#232)) ([d73381e](libp2p/js-libp2p-mplex@d73381e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #224
This will start the connection manager on
libp2p.startand stop it onlibp2p.stop. Previously users would need to start and stop it themselves.