Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 0.38.0 #1253

Merged
merged 1 commit into from
Aug 17, 2022
Merged

chore: release 0.38.0 #1253

merged 1 commit into from
Aug 17, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 15, 2022

πŸ€– I have created a release *beep* *boop*

0.38.0 (2022-08-17)

⚠ BREAKING CHANGES

  • Streams are now Duplex<Uint8ArrayList, Uint8ArrayList | Uint8Array>
  • connectionManager.peerValue has been removed, use peerStore.tagPeer instead
  • limit protocol streams per-connection (feat!: limit protocol streams per-connectionΒ #1255)
  • uses new single-issue libp2p interface modules

Features

Bug Fixes

deps

  • update all deps to support no-copy operations (#1335) (f439d9b)

This PR was generated with Release Please. See documentation.

@D4nte
Copy link
Contributor

D4nte commented Jul 22, 2022

@achingbrain, any chance we could get the release please? This contains few bug fixes I'd love to get :)
ChainSafe/js-libp2p-gossipsub#305 and libp2p/js-libp2p-mplex#191

@achingbrain
Copy link
Member

achingbrain commented Jul 22, 2022

@D4nte soon! I'm just treading carefully around some of the protocol stream limiting stuff as it will cause things to break if the limits are not set correctly.

Can you please try out the RC with npm i libp2p@next and report back any breakage?

@D4nte
Copy link
Contributor

D4nte commented Jul 22, 2022

@D4nte soon! I'm just treading carefully around some of the protocol stream limiting stuff as it will cause things to break if the limits are not set correctly.

Can you please try out the RC with npm i libp2p@next and report back any breakage?

I have actually been using master locally and yes, I found an issue with protocol stream limits and libp2p-gossipsub. I haven't had the time to write up an issue or PR yet.

In short, the outbound limit is being reached and throwing an error when connecting to a new peer because gossipsub tries to open an outbound stream.

This is because an outbound stream already exists but gossipsub class isn't aware of it. I guess libp2p opens the stream upon dial.

I was going to write a fix in gossipsub to check existing stream on libp2p and register it before trying to open

Will provide more details soon.

@D4nte
Copy link
Contributor

D4nte commented Jul 22, 2022

The issue I was referring to: ChainSafe/js-libp2p-gossipsub#306

@achingbrain achingbrain merged commit 29c803a into master Aug 17, 2022
@achingbrain achingbrain deleted the release-v0.38.0 branch August 17, 2022 19:39
@wemeetagain
Copy link
Member

πŸŽ‰ congrats @achingbrain

@github-actions
Copy link
Contributor Author

πŸ€– Release is at https://github.com/libp2p/js-libp2p/releases/tag/v0.38.0 🌻

achingbrain added a commit to ipfs/js-ipfs that referenced this pull request Aug 17, 2022
Updates all dependencies to allow use of `libp2p@0.38.x`.  See the [release issue](libp2p/js-libp2p#1253) for what's new!
SgtPooki pushed a commit to ipfs/js-kubo-rpc-client that referenced this pull request Aug 18, 2022
Updates all dependencies to allow use of `libp2p@0.38.x`.  See the [release issue](libp2p/js-libp2p#1253) for what's new!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants