This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: Unix domain sockets #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To get this working on windows systems I have had to use named pipes instead of unix domain sockets, see: https://nodejs.org/api/net.html#identifying-paths-for-ipc-connections. |
achingbrain
approved these changes
Sep 14, 2022
|
Thanks! |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to handle UNIX domain sockets.
/unixmultiaddresses but is unable to handle p2p encapsulated addresses (/unix/.../p2p/...) due to ambiguity. Because of this it causes errors when attempting to use/unixaddresses in js-libp2p because it appends the/p2paddress.Despite the fact that it does not work with
/unixaddresses in js-libp2p directly, this still remains useful and is needed in other projects like js-libp2p-daemon.This PR relates to issue #132.