This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Improve ip6 support #100
Closed
Improve ip6 support #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
libp2p should eventually handle listen versus announce addresses, this helps with ip6 support in the interim License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
ghost
assigned 
jacobheun
added
the
kind/enhancement
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
jacobheun
added
the
status/blocked
|
I want to do some more testing of the encapsulation changes. I think there are some integration issues with js-ipfs. I'm going to look into improving testing around those changes. |
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
chore: improve test listener closures License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
achingbrain
added a commit
that referenced
this pull request
Aug 30, 2022
Adds tests from #100 as the feature has been implemented already.
|
Superseded by #203 |
achingbrain
added a commit
that referenced
this pull request
Aug 30, 2022
Adds tests from #100 as the feature has been implemented already.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for ip4, TCP will replace
0.0.0.0in multiaddrs with the ip addresses from your ip4 network. For people using ip6 TCP doesn't do anything. The PR adds that support for ip6. Using an address like/ip6/::/tcp/9094, will replace the host with ip addresses from the ip6 network.This should help improve node connectivity for users running nodes on ip6 networks.
Other things in the PR
I'm running a local js-ipfs node with this change and the latest libp2p release candidate (0.24.0-rc.3).