Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

fix: cascading connection from encrypted connection to parent connection #98

Merged
merged 1 commit into from
Feb 27, 2018
Merged

fix: cascading connection from encrypted connection to parent connection #98

merged 1 commit into from
Feb 27, 2018

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Feb 22, 2018

@ghost ghost assigned pgte Feb 22, 2018
@ghost ghost added the in progress label Feb 22, 2018
@pgte
Copy link
Contributor Author

pgte commented Feb 22, 2018

Tests are timing out, but they were before this PR. Any clue on that?

@pgte pgte requested a review from daviddias February 22, 2018 15:58
@daviddias
Copy link
Member

@pgte locally as well? Seems that only one of the CI runs red. Perhaps increase the timeout to see what is the real reason?

@pgte
Copy link
Contributor Author

pgte commented Feb 22, 2018

@diasdavid locally it runs fine, and there is no test that's particularly long..
1__bash

@pgte pgte mentioned this pull request Feb 22, 2018
Merged
@pgte
Copy link
Contributor Author

pgte commented Feb 22, 2018

@diasdavid looks like everything is green again... 🤔

daviddias
daviddias approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Spinned CI again just for a last check

@daviddias daviddias merged commit e205ca4 into master Feb 27, 2018
@daviddias daviddias deleted the fix/set-parent-conn branch February 27, 2018 12:15
@ghost ghost removed the in progress label Feb 27, 2018
@jacobheun jacobheun mentioned this pull request Mar 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@pgte pgte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgte @daviddias