Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Add error responses to RPC handlers #64

Open
jacobheun opened this issue Dec 17, 2018 · 1 comment
Open

Add error responses to RPC handlers #64

jacobheun opened this issue Dec 17, 2018 · 1 comment
Assignees
@vasco-santos
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up

Comments

@jacobheun
Copy link
Contributor

Currently the js and go DHT implementation don't respond with errors from the rpc handlers, they just end the stream. This makes it difficult for someone to figure out what's going on with their implementation. For example, working on the libp2p-daemon, I was sending an invalid record key on put. The error caused the stream to terminate from the receiving dht node and no meaningful error is returned to the requesting node.

Adding Error responses to the protobuffs would allow us to better inform nodes of issues.
@vasco-santos vasco-santos self-assigned this Dec 17, 2018
@vasco-santos vasco-santos added exp/wizard Extensive knowledge (implications, ramifications) required P1 High: Likely tackled by core team if no one steps up kind/enhancement A net-new feature or improvement to an existing feature labels Dec 17, 2018
@vasco-santos
Copy link
Member

cc @jhiesey for the new spec

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vasco-santos vasco-santos

Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @vasco-santos