fix: decapsulate ipfs from dht find peer #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vasco-santos I wonder if we should also decapsulate the addresses at the end of |
|
I agree that it makes more sense to decapsulate the addresses at the end of |
vasco-santos
force-pushed
the
fix/decapsulate-ipfs-from-dht-find-peer
branch
from
563fa0b
to
d13d799
Compare
jacobheun
reviewed
Mar 7, 2019
src/libp2p.js
Outdated
| } catch (_) { | ||
| ma = m | ||
| } | ||
| return ma |
There was a problem hiding this comment.
It would be good to replace map with forEach and do this.peerInfo.multiaddrs.replace(m, ma) here to avoid the additional iteration.
vasco-santos
force-pushed
the
fix/decapsulate-ipfs-from-dht-find-peer
branch
from
d13d799
to
8fe49ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
js-libp2pdoes not handle this on libp2p/js-libp2p#323, this PR removes the/ipfs/{peer_id}from the multiaddress