You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 26, 2022. It is now read-only.
ifstrings.Contains(err.Error(), "use of closed network connection") {
c.closedConn(conn)
continue
}
log.Errorf("Failed to get TCP info: %s", err)
continue
}
where if we're unable to get the TCP info we never clean it up. e.g. on Windows I see the following error:
2021-07-08T21:39:47.925-0400 ERROR tcp-tpt go-tcp-transport@v0.2.2/metrics.go:118 Failed to get TCP info: raw-control tcp 192.168.1.6:4001: getsockopt: not implemented
The text was updated successfully, but these errors were encountered:
At the moment we have a global variable for TCP metrics
go-tcp-transport/metrics.go
Line 23 in 1b96803
Which has a map of connections
go-tcp-transport/metrics.go
Line 58 in 1b96803
That we only clear out when the metrics are collected
go-tcp-transport/metrics.go
Line 106 in 1b96803
We should clear out these connections more predictably (e.g. on connection close or some background goroutine).
There might also be a bug related to the cleanup itself
go-tcp-transport/metrics.go
Lines 110 to 120 in 1b96803
where if we're unable to get the TCP info we never clean it up. e.g. on Windows I see the following error:
The text was updated successfully, but these errors were encountered: