revert yamux back to my patch pending hashicorp/yamux#30 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM but name field disappeared |
|
dammit. I even filed an issue for it before pushing and i still forgot to fix it: whyrusleeping/gx#75 |
whyrusleeping
force-pushed
the
revert-yamux
branch
from
61053a2
to
d08ebb3
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Jan 17, 2022
marten-seemann
added a commit
that referenced
this pull request
Apr 19, 2022
add a WithEventBus constructor option
marten-seemann
pushed a commit
that referenced
this pull request
Apr 22, 2022
fix: don't allow dialing DNS addresses
marten-seemann
pushed a commit
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverting this until hashicorp/yamux#30 is fixed