Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/http: cache json wellknown mappings in the .well-known handler #2537

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 29, 2023

We are expecting this to be vastly read dominated, caching this makes sense.

We are expecting this to be vastly read dominated, caching this makes sense.
@Jorropo Jorropo requested a review from MarcoPolo August 29, 2023 10:18
@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 29, 2023

2023-08-29T10:34:18.3807361Z === RUN   TestSingleCandidate
2023-08-29T10:34:18.3896197Z     autorelay_test.go:137: 
2023-08-29T10:34:18.3901183Z         	Error Trace:	D:/a/go-libp2p/go-libp2p/p2p/host/autorelay/autorelay_test.go:137
2023-08-29T10:34:18.3904419Z         	Error:      	Condition never satisfied
2023-08-29T10:34:18.3906688Z         	Test:       	TestSingleCandidate
2023-08-29T10:34:18.3908211Z --- FAIL: TestSingleCandidate (10.13s)

Unrelated CI flake

@MarcoPolo MarcoPolo merged commit 4eb5ba5 into libp2p:master Aug 29, 2023
11 checks passed
@Jorropo Jorropo deleted the cache-well-known-mappings branch August 30, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants