swarm: remove unnecessary reqno for pending request tracking #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2023
p2p/net/swarm/dial_worker.go
Outdated
| @@ -48,7 +48,7 @@ type pendRequest struct { | |||
| // At the time of creation addrs is initialised to all the addresses of the peer. On a failed dial, | |||
| // the addr is removed from the map and err is updated. On a successful dial, the dialRequest is | |||
| // completed and response is sent with the connection | |||
| addrs map[string]struct{} | |||
| addrs map[string]bool | |||
There was a problem hiding this comment.
Add a comment what the bool means?
There was a problem hiding this comment.
I don't see it being set to false ever. Do we actually need a bool here?
There was a problem hiding this comment.
updated both, addrs and pendingRequests to map to struct{}
marten-seemann
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the order of the PRs here #2380
Will take ErrBackoff modification in a follow up PR