webtransport: move certhash verification to the client #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
MarcoPolo
approved these changes
Sep 17, 2022
| return &connSecurityMultiaddrs{ | ||
| ConnSecurity: c, | ||
| ConnMultiaddrs: &connMultiaddrs{local: local, remote: remote}, | ||
| }, nil | ||
| } | ||
|
|
||
| func decodeCertHashesFromProtobuf(b []byte) ([]multihash.DecodedMultihash, error) { | ||
| var msg pb.WebTransport | ||
| if err := msg.Unmarshal(b); err != nil { |
There was a problem hiding this comment.
should we error if len(b) == 0? (The unmarshal will not fail this I think)
There was a problem hiding this comment.
might be okay. A server sending an empty early data can be interpreted to mean that there is no certhash. Just a bit surprising
marten-seemann
force-pushed
the
new-webtransport-noise-handshake
branch
from
5500965
to
5ebda4d
Compare
marten-seemann
force-pushed
the
new-webtransport-noise-handshake
branch
from
5ebda4d
to
6795012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in libp2p/specs#455.
This PR builds on top #1750. Please only review the last commit. I'll rebase this PR once #1750 is merged.