Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md: point to the right location for examples. #133

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Readme.md: point to the right location for examples. #133

merged 1 commit into from
Oct 25, 2016

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Oct 5, 2016

The linked repo seems to have been left behind vs the examples folder which contains working examples.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan mentioned this pull request Oct 5, 2016
@RichardLitt
Copy link
Member

Should we not move https://github.com/whyrusleeping/libp2p-examples/ to libp2p, instead?

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Oct 5, 2016

The only example in libp2p-examples (hosts) is already part of the examples folder in go-libp2p. It would seem to me that libp2p-examples repo is a left over and this was just an old reference. That repo is not maintained and does not really work anymore.

@RichardLitt
Copy link
Member

Sounds good to me. That seems to be only referenced in this repo, in all of GitHub, so just changing the link should work.

Copy link
Contributor

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyrusleeping whyrusleeping merged commit 6d069ac into libp2p:master Oct 25, 2016
marten-seemann added a commit that referenced this pull request Jul 1, 2022
fix race condition in TestActiveRelay
marten-seemann pushed a commit that referenced this pull request Aug 9, 2022
Fix memory store signed peer record bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants