autorelay support for circuitv2 relays #1198
Conversation
static checker complains; sigh.
|
@marten-seemann ready for another round of review. |
| if now.Add(rsvpExpirationSlack).Before(rsvp.Expiration) { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
I must have missed this in my earlier review, but do we need a check to garbage collect expired reservations?
There was a problem hiding this comment.
I don't think so, we'll try to refresh them. Do you see any way to create garbage here?
There was a problem hiding this comment.
You're right, we delete the reservation if refreshing fails.
| } | ||
|
|
||
| select { | ||
| case <-ready: |
There was a problem hiding this comment.
This will leave all but the first go routine blocked on their IdentifyWait, doesn't it? Maybe this would a good use case for https://pkg.go.dev/golang.org/x/sync/errgroup#WithContext?
There was a problem hiding this comment.
No, the channel is buffered for len(conns), so we should be fine.
vyzo
force-pushed
the
feat/autorelayv2
branch
from
1fd4461
to
ba1444f
Compare
Changes:
p2p/host/autorelayNext steps: refactor the relay discovery logic to support the Flare strategy of an army of relays; this can happen in a subsequent pr, and we can even wait for deployment before we do it.
For now, user must configure relays statically.