Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't turn off logging #392

Closed
marten-seemann opened this issue Aug 9, 2018 · 2 comments · Fixed by #408
Closed

don't turn off logging #392

marten-seemann opened this issue Aug 9, 2018 · 2 comments · Fixed by #408
Assignees

Comments

@marten-seemann
Copy link
Contributor

golog.SetOutput(ioutil.Discard)
turns off logging completely.
quic-go uses the go standard logger (but introduces a log level which can be set via an env variable, so quic-go is quiet by default). However, this line prevents quic-go from logging at all.

@marten-seemann
Copy link
Contributor Author

The issue here is that mdns logs a lot. We definitely need a way to shut it up.

I see two practical ways to do so:

  1. use go-log for mdns, and log everything at the lowest log level, i.e. debug. Maybe that's still too noisy though.
  2. modify mdns such that it doesn't log any more. Shouldn't be too much work, it's just 11 log statements in total.

@whyrusleeping, wdyt?

@Stebalien
Copy link
Member

Wow, yeah, we shouldn't do that. We've been trying to switch to a newer fork of our current MDNS library to fix some other issues (races) but... grandcat/zeroconf#38.

It may be worth it to just fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants