Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renable pion logs for webrtc transport #2921

Open
sukunrt opened this issue Aug 14, 2024 · 0 comments · May be fixed by #2952
Open

Renable pion logs for webrtc transport #2921

sukunrt opened this issue Aug 14, 2024 · 0 comments · May be fixed by #2952

Comments

@sukunrt
Copy link
Member

sukunrt commented Aug 14, 2024

As the pion logs are too noisy, #2915 disables them.

We should reenable these logs after fixing the log level logs. In most cases these can simply be downgraded to debug, as these aren't error conditions.
For example this log line

2024-08-06T15:09:24.337-0700    ERROR   webrtc-transport-pion   v3@v3.2.50/sctptransport.go:184 Failed to accept data channel: failed to send ChannelOpen ACK: stream closed

happens whenever there the webrtc connection is closed and concurrently remote creates a datachannel. This is not an error condition for the connection.

@sukunrt sukunrt linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant