Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when trying to dial /quic peer #2515

Closed
Tracked by #2481
Jorropo opened this issue Aug 23, 2023 · 1 comment · Fixed by #2524
Closed
Tracked by #2481

Better error message when trying to dial /quic peer #2515

Jorropo opened this issue Aug 23, 2023 · 1 comment · Fixed by #2524

Comments

@Jorropo
Copy link
Contributor

Jorropo commented Aug 23, 2023

Using v0.30.0:
Currently .Error() gives:

Error: failed to dial: failed to dial $PEERID:
  * [/ip4/$IP/udp/4001/quic] unknown QUIC version

I would rather see something along the lines of:

Error: failed to dial: failed to dial $PEERID:
  * [/ip4/$IP/udp/4001/quic] QUIC draft 29 has been removed, QUIC RFC9000 is accessible with /quic-v1

I think a self explanatory error message is warranted here because this used to work and now it don't.
Note that this will be shown if all dials fail.
This was referenced Aug 24, 2023
Closed
Closed
@marten-seemann marten-seemann linked a pull request Aug 25, 2023 that will close this issue
swarm: return a more meaningful error when dialing QUIC draft-29 #2524
Merged
@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 25, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Jorropo