-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed to start relay finder: relayFinder already running #2234
Comments
we probably check if is already running and not try to start it again. Want to take a stab at fixing it? |
Hope to fix it . Thank you. Cause this error won't have any effect to functionity but people will get confused. |
I think @sukunrt already has a fix for this. |
this will be fixed by #2185 and #2225 however those are PRs for separate issues so a separate PR for this should be fine. go-libp2p/p2p/host/autorelay/autorelay.go Lines 87 to 95 in b78104d
|
@sukunrt Is this fixed now? |
yeah this should be fixed now |
I start a node in my local mac, and sometimes this error will show up:
2023-01-04T11:42:33.113+0800 ERROR autorelay autorelay/autorelay.go:80 failed to start relay finder {"error": "relayFinder already running"}
It sounds like that most time it appeared after my mac running a whole night , or I close my mac.
I have seen your code, is it because that when network changed, libp2p try to start relayFinder again?
Should this error be ignored?
go-libp2p v0.24.2
The text was updated successfully, but these errors were encountered: