Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

remove unused context in Swarm.dialWorkerLoop #268

Merged
merged 1 commit into from
Aug 23, 2021
Merged

remove unused context in Swarm.dialWorkerLoop #268

merged 1 commit into from
Aug 23, 2021

Conversation

marten-seemann
Copy link
Contributor

No description provided.

Stebalien
Stebalien approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so we just wait for the request channel to terminate? Makes sense.

@marten-seemann
Copy link
Contributor Author

Ah, so we just wait for the request channel to terminate? Makes sense.

Apparently that's what we do. Just trying to clean things up a bit.
I honestly don't understand the 250 line dialWorkerLoop. There's not a lot of useful documentation in the code, and I don't find it very obvious to begin with.

@marten-seemann marten-seemann force-pushed the remove-unused-context branch 2 times, most recently from ba4cd96 to 21500a3 Compare August 23, 2021 20:56
@marten-seemann marten-seemann merged commit f3ae0cb into master Aug 23, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien