This repository has been archived by the owner on May 26, 2022. It is now read-only.
Implement CloseRead/CloseWrite #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll probably need to write interface shims anyways. |
This: * Changes `Close` to behave like the unix `close` (sends an EOF, ignores future inbound data). * Adds a `CloseWrite` to replace the current `Close`. * Adds a `CloseRead` to close the read side, while leaving the write side open. See libp2p/go-libp2p-core#166.
Stebalien
force-pushed
the
feat/rw-close
branch
from
dec9c85
to
126c647
Compare
|
@marten-seemann could you merge this when you're ready? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Closeto behave like the unixclose(sends an EOF, ignores future inbound data).CloseWriteto replace the currentClose.CloseReadto close the read side, while leaving the write side open.See libp2p/go-libp2p-core#166.
Depends on libp2p/go-libp2p-core#166, don't merge until that's merged.