Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator should see the peer that forwarded the message #150

Closed
vyzo opened this issue Jan 16, 2019 · 0 comments
Closed

Validator should see the peer that forwarded the message #150

vyzo opened this issue Jan 16, 2019 · 0 comments
Assignees

Comments

@vyzo
Copy link
Collaborator

vyzo commented Jan 16, 2019

With the addition of blacklists in #149 we can now null-route misbehaving peers that send invalid messages.
The primary decider for black-listing is the validator: it is application-specific and in position to detect invalid messages.

However, the validator interface currently only includes the message itself.
That means that the validator cannot see the peer that forwarded the message, only the original source of the message.
This severely limits the ability to detect misbehaving peers that replay old messages from other peers.

Proposed action:

  • extend the validator interface to include the peer that forwarded the message.
@ghost ghost assigned vyzo Jan 17, 2019
@ghost ghost added the in progress label Jan 17, 2019
@vyzo vyzo closed this as completed in #151 Jan 17, 2019
@ghost ghost removed the in progress label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant