From 491519a817a5776527428ecc63ef09d3e313d221 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Fri, 28 Jun 2019 13:26:17 +0200 Subject: [PATCH] reduce allocations when adding addrs --- pstoremem/addr_book.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pstoremem/addr_book.go b/pstoremem/addr_book.go index 1a4bcca..19b60f9 100644 --- a/pstoremem/addr_book.go +++ b/pstoremem/addr_book.go @@ -154,10 +154,10 @@ func (mab *memoryAddrBook) AddAddrs(p peer.ID, addrs []ma.Multiaddr, ttl time.Du log.Warningf("was passed nil multiaddr for %s", p) continue } - addrstr := string(addr.Bytes()) - a, found := amap[addrstr] + asBytes := addr.Bytes() + a, found := amap[string(asBytes)] // won't allocate. if !found || exp.After(a.Expires) { - amap[addrstr] = &expiringAddr{Addr: addr, Expires: exp, TTL: ttl} + amap[string(asBytes)] = &expiringAddr{Addr: addr, Expires: exp, TTL: ttl} mab.subManager.BroadcastAddr(p, addr) } @@ -188,14 +188,14 @@ func (mab *memoryAddrBook) SetAddrs(p peer.ID, addrs []ma.Multiaddr, ttl time.Du log.Warningf("was passed nil multiaddr for %s", p) continue } - // re-set all of them for new ttl. - addrstr := string(addr.Bytes()) + // re-set all of them for new ttl. + aBytes := addr.Bytes() if ttl > 0 { - amap[addrstr] = &expiringAddr{Addr: addr, Expires: exp, TTL: ttl} + amap[string(aBytes)] = &expiringAddr{Addr: addr, Expires: exp, TTL: ttl} mab.subManager.BroadcastAddr(p, addr) } else { - delete(amap, addrstr) + delete(amap, string(aBytes)) } } }