Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

fix: re-enable peer ID inlining but make it configurable #42

Merged
merged 1 commit into from
Feb 7, 2019
Merged

fix: re-enable peer ID inlining but make it configurable #42

merged 1 commit into from
Feb 7, 2019

Conversation

Stebalien
Copy link
Member

This should:

  1. Unblock OpenBazaar. They were relying on the non-inlining behavior but run a forked network so they can set EnableDeprecatedKeyInlining to false.
  2. Unblock Textile. They rely on this feature being enabled. Re-enabling it by default will give us some time to transition away from it.

@ghost ghost assigned Stebalien Jan 23, 2019
@ghost ghost added the in progress label Jan 23, 2019
@Stebalien Stebalien mentioned this pull request Jan 29, 2019
Closed
@Stebalien
Copy link
Member Author

@hoffmabc does this work for OpenBazaar? See: libp2p/specs#138

@Stebalien
Copy link
Member Author

cc @cpacia

@Stebalien
Copy link
Member Author

CC @parkan.

@parkan
Copy link

parkan commented Feb 5, 2019

also paging @placer14

@placer14
Copy link

placer14 commented Feb 5, 2019

I wasn't aware of the conversation. I'll raise it with the team and get back to you guys. Thanks for the consideration. 🥇

@Stebalien
fix: re-enable peer ID inlining but make it configurable
876cefc 
This should:

1. Unblock OpenBazaar. They were relying on the non-inlining behavior but run a
   forked network so they can set `EnableDeprecatedKeyInlining` to `false`.
2. Unblock Textile. They rely on this feature being *enabled*. Re-enabling it by
   default will give us some time to transition away from it.
@Stebalien
Copy link
Member Author

I've changed the flag to AdvancedEnableInlining and added a bunch of warnings/caveats to make it clear that this isn't something users should touch unless they know what they're doing.

@Stebalien
Copy link
Member Author

Merging as this simply restores the current behavior.

@Stebalien Stebalien merged commit e96065a into master Feb 7, 2019
@ghost ghost removed the in progress label Feb 7, 2019
@Stebalien Stebalien deleted the fix/re-enable-inlining branch February 7, 2019 23:01
@sanderpick
Copy link

Nice, cheers @Stebalien

@Stebalien
Copy link
Member Author

@sanderpick this has been merged into master, along with the DHT dialing fixes.

@sanderpick
Copy link

Okay, great. I'm under full siege this week... will update our node with go-ipfs master next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stebalien @parkan @placer14 @sanderpick @vyzo