Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky TestSearchValue test #723

Closed
marten-seemann opened this issue Jun 14, 2021 · 2 comments · Fixed by #1038
Closed

flaky TestSearchValue test #723

marten-seemann opened this issue Jun 14, 2021 · 2 comments · Fixed by #1038
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor 

  === RUN   TestSearchValue
      dht_test.go:463: expected 'newer', got ''
  --- FAIL: TestSearchValue (0.07s)
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Jun 14, 2021
@marten-seemann marten-seemann mentioned this issue Jun 14, 2021
Merged
@guillaumemichel
Copy link
Contributor

I wasn't able to reproduce locally. Closing for now, and I will reopen if the test is flaking again on the CI.

@guillaumemichel
Copy link
Contributor

guillaumemichel commented Feb 18, 2025 •
edited
Loading 

=== RUN   TestSearchValue
    dual_test.go:315: failed to find any peer in table
    dual_test.go:328: incorrect best search value
--- FAIL: TestSearchValue (0.11s)

https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/13395386654/job/37412981645#step:15:1260

@guillaumemichel guillaumemichel mentioned this issue Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky TestSearchValue (dual) libp2p/go-libp2p-kad-dht
2 participants
@marten-seemann @guillaumemichel